Skip to content

fix: normalize string values and keys in ContentSecurityPolicy::addOption() - #10636

Open
gr8man wants to merge 1 commit into
codeigniter4:developfrom
gr8man:fix/csp-add-option-string-conversion
Open

gr8man wants to merge 1 commit into
codeigniter4:developfrom
gr8man:fix/csp-add-option-string-conversion

Conversation

@gr8man

@gr8man gr8man commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Description
Fixed ContentSecurityPolicy::addOption() and addToHeader() converting string values directly into array keys, which created invalid entries for empty strings, prevented keyword quoting for space-separated lists, and caused a fatal TypeError in PHP 8 strict mode when numeric strings were converted to integer array keys.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@carson-codeigniter4 carson-codeigniter4 Bot added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant