Skip to content

fix: make ContentSecurityPolicy::setDefaultSrc() add directives instead of overwriting - #10635

Open
gr8man wants to merge 1 commit into
codeigniter4:developfrom
gr8man:fix/csp-set-default-src
Open

fix: make ContentSecurityPolicy::setDefaultSrc() add directives instead of overwriting#10635
gr8man wants to merge 1 commit into
codeigniter4:developfrom
gr8man:fix/csp-set-default-src

Conversation

@gr8man

@gr8man gr8man commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Description
Fixed ContentSecurityPolicy::setDefaultSrc() overwriting existing directives instead of adding to them, and failing when passed an array of URIs. Also added addDefaultSrc() for consistency with other CSP directive methods.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@carson-codeigniter4 carson-codeigniter4 Bot added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gr8man