Repository navigation
fix: ask the CodeIgniter namespace confirmation once in make:cell and make:model - #10621
Merged
Merged
Conversation
… and `make:model`
michalsn
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
make:cellasked theCodeIgniternamespace confirmation twice, once for the class and once for the view.make:model --return entityasked it again when callingmake:entity.AbstractGeneratorCommandnow remembers the answer for the currentgenerateClass()and reuses it for the views generated after it. The nextgenerateClass()asks again.make:modelcallsmake:entitywithnoInteractionOverride: true, so the entity only prints the warning. When the confirmation is declined,make:entityis skipped through the new protectedisCodeIgniterNamespaceDeclined()hook.make:scaffoldis unchanged and still asks once per sub-generator. Forcing its sub-generators non-interactive would also drop their own prompts, so an invalid--restfulor--returnvalue would fail instead of prompting for a valid one.Checklist: