Repository navigation
fix(multiple): allow aria tab and accordion panels without content directive - #33966
Open
felipdsa21 wants to merge 3 commits into
Open
felipdsa21 wants to merge 3 commits into
felipdsa21 wants to merge 3 commits into
Conversation
felipdsa21
force-pushed
the
aria-eager-panel-content
branch
from
October 16, 2026 16:45
f50b2a7 to
baebc18
Compare
By default, the content of `ngTabContent` and `ngAccordionContent` is created again each time the panel is shown, not only the first time.
…rective Content placed directly in `ngTabPanel` or `ngAccordionPanel` is rendered eagerly, but a dev-mode warning claims the panel needs `ngTabContent` or `ngAccordionContent` to render. Removes the warning so eager content is supported alongside lazy content. Fixes angular#33950
felipdsa21
force-pushed
the
aria-eager-panel-content
branch
from
October 18, 2026 18:56
baebc18 to
9535ecf
Compare
angular-robot
Bot
added
area: docs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ngTabPanelandngAccordionPaneldirectives warn in dev mode that they needngTabContentorngAccordionContentto render, but content placed directly in a panel already renders. It's created eagerly and stays in the DOM, and the panel gets theinertattribute while hidden.This removes the warning, making eager rendering a supported alternative to the content directive. A single tab group or accordion can then mix eager panels with lazy ones, which keep or remove their content depending on their own
preserveContent.Rendering eagerly also means the content is included in server-rendered HTML, unlike lazy content.
Fixes #33950