Skip to content

⚡ Bolt: Optimize dominator tree HashSet allocations - #286

Merged
github-actions[bot] merged 1 commit into
mainfrom
bolt-optimize-dominators-hashsets-6626739967144321662
Oct 14, 2026
Merged

github-actions[bot] merged 1 commit into
mainfrom
bolt-optimize-dominators-hashsets-6626739967144321662

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

💡 What: Replaced repeated HashSet allocations and cloning inside the iterative dominator tree solver loop with a single pre-allocated HashSet that uses .clear(), .extend(), and .retain() for in-place intersections. We also use .clone_from() for updating existing dominator sets.
🎯 Why: Prevents excessive HashSet allocations inside a tight inner loop, which significantly hurt performance during dataflow analysis.
📊 Impact: Reduces heap allocations and speeds up the dominator analysis compiler pass by avoiding O(N) intermediate HashSet instantiations per block per loop iteration.
🔬 Measurement: Run the test suite and benchmark suite to verify the logic remains correct while reducing peak memory usage and compilation time.


PR created automatically by Jules for task 6626739967144321662 started by @Tcode-Motion

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
github-actions Bot marked this pull request as ready for review October 14, 2026 04:55
@github-actions
github-actions Bot merged commit a46a643 into main Oct 14, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant