Repository navigation
⚡ Bolt: Optimize dominator tree HashSet allocations - #286
github-actions[bot] merged 1 commit into
Conversation
Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced repeated
HashSetallocations and cloning inside the iterative dominator tree solver loop with a single pre-allocatedHashSetthat uses.clear(),.extend(), and.retain()for in-place intersections. We also use.clone_from()for updating existing dominator sets.🎯 Why: Prevents excessive
HashSetallocations inside a tight inner loop, which significantly hurt performance during dataflow analysis.📊 Impact: Reduces heap allocations and speeds up the dominator analysis compiler pass by avoiding O(N) intermediate
HashSetinstantiations per block per loop iteration.🔬 Measurement: Run the test suite and benchmark suite to verify the logic remains correct while reducing peak memory usage and compilation time.
PR created automatically by Jules for task 6626739967144321662 started by @Tcode-Motion