Skip to content

fix(charts): return notFound for invalid catalog collection IDs - #1377

Merged
tannerlinsley merged 1 commit into
mainfrom
seer/fix/charts-catalog-collection-id-not-found
Oct 13, 2026
Merged

tannerlinsley merged 1 commit into
mainfrom
seer/fix/charts-catalog-collection-id-not-found

Conversation

@sentry

@sentry sentry Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Pre-validate params.collectionId in the charts catalog collection route loader using isChartsCatalogCaseId and throw notFound() before calling getChartsCatalogCollection. This prevents malformed IDs (such as requests ending in .md, like shadcn.md) from triggering an unhandled Valibot schema validation exception from the server function validator.

Fixes TANSTACK-COM-5AH

@sentry <feedback>: Autofix iterates on these changes
@sentry stop iterating: Autofix stops iterating on this run

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@changeset-bot

changeset-bot Bot commented Oct 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 379f8ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5f0c1d95-83d0-4f75-bf57-f031bb6d913c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 379f8ab Oct 13 2026, 11:19 PM

@tannerlinsley
tannerlinsley merged commit d30aa71 into main Oct 13, 2026
8 checks passed
@tannerlinsley
tannerlinsley deleted the seer/fix/charts-catalog-collection-id-not-found branch October 13, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant