Repository navigation
Keep namespaced package changes distinct - #404
Open
John-David Dalton (jdalton) wants to merge 1 commit into
Open
John-David Dalton (jdalton) wants to merge 1 commit into
John-David Dalton (jdalton) wants to merge 1 commit into
Conversation
Retain npm scopes and Maven groups when deduplicating package changes. Keep existing filtering, order, and true-duplicate behavior. Assisted-by: Codex:GPT-6
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Description written by Codex:GPT-6
Keep distinct npm scopes and Maven groups in dependency-change reports.
Root Cause
Package lists deduplicated by ecosystem, name, and version, dropping the namespace. For example,
@one/widget@1.0.0and@two/widget@1.0.0collapsed into one row.Fix
Builds on #403. No output schema or release changes.
Validation
55 focused and related identity/URL tests pass with the real CLI core and SDK against a local HTTP fixture. Scoped Ruff lint, test formatting, and diff checks pass. Independent source review found no blockers. Core retains pre-existing whole-file formatting differences.
Public Changelog
Preserve distinct package scopes and groups in dependency-change reports.
Note
Medium Risk
Changes how package rows are deduplicated in diff/JSON reports; behavior is narrower in scope but affects what CI and reviewers see for dependency changes.
Overview
Dependency-change deduplication now includes namespace, so scoped npm packages and Maven groups with the same name/version no longer merge into a single row in JSON and other diff outputs.
create_diff_reportreplaces the oldecosystem/name@versionstring key with a(ecosystem, namespace, name, version)identity (treating missing and empty namespace the same). First occurrence still wins for true duplicates within a bucket; added/updated/removed/replaced lists stay separate, and direct-only filtering is unchanged.New transport tests cover diff-scan and streaming fallback paths, PURLs/URLs per scope, and cross-bucket behavior.
Reviewed by Cursor Bugbot for commit 60183b1. Configure here.