Repository navigation
Bug fix for Set-PSResourceRepository dynamic parameter - #2067
Open
alerickson wants to merge 2 commits into
Open
alerickson wants to merge 2 commits into
alerickson wants to merge 2 commits into
Conversation
alerickson
requested review from
Sydney Smith (SydneyhSmith),
Aditya Patwardhan (adityapatwardhan),
Anam Navied (anamnavi) and
shammu1
as code owners
October 16, 2026 17:47
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
🟡 Changes recommended
The missing-store scenario needs an automated regression test because existing tests pre-create the store.
1 open finding
What changed in this PR
Fixes the fresh-install failure reported in #2066 by initializing the repository store before dynamic parameter discovery reads it.
Changes:
- Moves
CheckRepositoryStore()intoGetDynamicParameters(). - Removes the redundant
BeginProcessing()override.
| File | Description |
|---|---|
| src/code/SetPSResourceRepository.cs | Initializes the repository store before dynamic parameter discovery. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Summary
This PR moves
CheckRepositoryStore()fromBeginProcessing()to the start ofGetDynamicParameters()because PowerShell calls them in this order:Previously, dynamic parameter discovery tried to read the repository store before it had been created. On a fresh installation, that threw an exception, so execution never reached the initialization in
BeginProcessing().Initializing immediately before the read fixes that ordering problem using the existing initialization logic. The old
BeginProcessing()override was removed because it would only repeat the same check.PR Context
Resolves issue #2066
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.