Repository navigation
Add concurrent queues to necessary methods - #2064
Merged
Merged
Conversation
alerickson
requested review from
Sydney Smith (SydneyhSmith),
Aditya Patwardhan (adityapatwardhan),
Anam Navied (anamnavi) and
shammu1
as code owners
October 14, 2026 19:01
Member
Author
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
🟡 Changes recommended
The concurrency fix lacks regression coverage that exercises extraction on worker threads.
1 open finding
What changed in this PR
Routes platform-filtering diagnostics through thread-safe queues to prevent worker threads from writing directly to PowerShell streams.
Changes:
- Passes warning/debug queues through extraction helpers.
- Queues TFM/RID filtering diagnostics for pipeline-thread output.
| File | Description |
|---|---|
src/code/InstallHelper.cs |
Replaces worker-thread Write* calls with queued messages. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Aditya Patwardhan (adityapatwardhan)
approved these changes
Oct 15, 2026
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Resolves 2 bugs:
Install-PSResourcewas failing with a "WriteObject and WriteError methods cannot be called" error because the new framework (TFM) and platform (RID) filtering inTryExtractToDirectory,GetBestLibFrameworkandWarnIfCrossLineageTfmSkippedwrote debug and warning messages directly from worker threads. These three methods have now been changed to add their messages to the existing warningMsgs and debugMsgs queues instead, and the pipeline thread writes them out after the parallel downloads finish.Install-PSResourcewas reinstalling dependencies that were already installed, a regression from the concurrent-install rewrite (v1.2.0 skipped them). On OneDrive-synced module folders, that reinstall copies the existing version to a temp backup first, which forced OneDrive to download cloud-only files and failed the install.DownloadParentAndDepsnow skips dependencies whose exact version is already installed, unless-Reinstall,-TargetFrameworkor-RuntimeIdentifieris given.PR Context
This resolves issue #2061
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.