fix(cli): make Enter skip resource-creating configure-gcp steps

[cristim]

Refs #1613. This covers the GCP half of finding A10-030. The Azure half (cmd/configure_azure.go) follows after the open #2212 lands, since that PR touches the same file.

Summary

In the configure-gcp wizard, pressing Enter at a [R]un, [S]kip? prompt ran the step: it created the service account, granted roles, minted a key, or ran gcloud auth login / ADC login. A stray Enter therefore made real changes to cloud identities.

• Enter now skips at all four prompts. "" moved from the run case to the skip case at each one:
  • create service account
  • grant roles
  • create key
  • promptAndRunGCPCommand, which handles auth and ADC login
• The prompts show the default: [r]un, [S]kip (default)?. Enter prints the step's normal skip message rather than "Unknown option". Unknown input already skipped, so its behaviour is unchanged.
• Login steps also default to skip. They affect identity, and if they are skipped by mistake, the next SDK step fails loudly on missing ADC.
• docs/cli/cloud-setup.md and CHANGELOG.md describe the new default.
• The configure_gcp_iam_test.go "empty" scenario asserted the old Enter-runs behaviour, so it is removed. It was otherwise identical to the "create" scenario. The wizard-driving fixtures already send an explicit r.

Evidence (local, macOS, GOTOOLCHAIN=go1.26.9, stubbed Google API, no GCP calls)

• Fail before / pass after: the new cmd/configure_gcp_default_skip_test.go drives "", r and s through all four steps.
  • With origin/main's configure_gcp.go, the four empty-input cases fail.
  • With the fix, they pass, and the test asserts the skip message and no "Unknown option".
• Mutation probes: putting "" back on the run case fails create-key/empty and TestPromptAndRunGCPCommand_DefaultIsSkip.
• Checks:
  • make build passes.
  • go vet ./... passes.
  • go test -race ./cmd/ passes (1568) on the rebased tree.
  • The GCP tests pass with -count=3 -race.
  • golangci-lint v2.10.1 reports 0 issues.
  • scripts/test-git-secrets-allowlist.sh passes 44/44.
• Review: an independent non-author reviewer (sonnet, high) did two passes.
  • It judged the login-step default.
  • It confirmed that no "" run-defaults remain in configure_gcp.go and that no coverage was lost.
  • Its one nit, the misleading "Unknown option" text on Enter, is applied.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 5 billable files and costs up to $1.25.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 21 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 68 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository: LeanerCloud/cloud-commitments-cli/.coderabbit.yaml
• Review profile: CHILL
• Plan: Essentials
• Run ID: f84f2854-f39c-408d-9d5e-9848d1e270d0

📥 Commits

Reviewing files that changed from the base of the PR and between 20cfdeb and ec929b0.

📒 Files selected for processing: 5

• CHANGELOG.md
• cmd/configure_gcp.go
• cmd/configure_gcp_default_skip_test.go
• cmd/configure_gcp_iam_test.go
• docs/cli/cloud-setup.md

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[cristim]

Independent review verdict: CLEAN at ec929b0

Reviewer: fresh Claude agent (Sonnet, high effort), not the author, cold brief. The PR body was treated as a claim. Coordinator: claude-cc-reviewer.

Blocking findings: none. No step that creates or changes a resource still runs on Enter.

Prompt (cmd/configure_gcp.go)	Creates or changes	Enter: before → after
gcloud auth login :734 (via promptAndRunGCPCommand :1013)	local identity only	run → skip
ADC login :745	local identity only	run → skip
Create service account :805	SA	run → skip, then asks for an existing SA email
Grant roles :900	custom role and IAM policy	run → skip
Create key :947	SA key	run → skip
Project listing :765 (shared promptRunOrSkipListing)	read-only	run (unchanged)
"Continue anyway?" :1058		already N

Non-interactive input:

• The CLI has no --yes or --non-interactive flag.
• EOF on empty input errors out of ReadString/readTrimmedLine and aborts the wizard; it is never read as yes.
• Piped bare Enters now skip each step with "Skipping …", and a later step fails loudly. Nothing is skipped silently.

Prompt text, CHANGELOG and docs:

• All four changed prompts read [r]un, [S]kip (default)?, which matches the code.
• The CHANGELOG and docs/cli/cloud-setup.md are accurate.

Notes (non-blocking):

• The two login steps also flip to skip-by-default. They touch only local identity, not cloud resources.
• The "Skipping …" message could say how to run the step manually.

What was attacked and how (no GCP calls):

• go vet ./cmd/... is clean. go test -race -count=1 ./cmd/... passes 1568.
• Fail-before: with main's configure_gcp.go, the create-service-account, grant-roles and create-key /empty cases fail, and so does TestPromptAndRunGCPCommand_DefaultIsSkip/empty.
• Mutation probe: restoring the empty default to "run" on grant-roles fails grant-roles/empty. A second probe was a no-op because of BSD sed, so it proves nothing.

Gate: no closing issue, and the PR carries its own triage labels. Merge once CI is green and the CodeRabbit gate is met.

[cristim]

CR waived: quota, adversarial review + local verification + green CI (per CLAUDE.md:172-173). CodeRabbit posted 'Review limit reached'. Gate at ec929b0: CLEAN verdict, CI green, mergeability CLEAN. #2240 and #2244 (the earlier configure_gcp.go changes) are in this branch's base, and main has not touched the file since. (claude-cc-reviewer)