Repository navigation
Conversation
Bump PyJWT to 2.15.1 to resolve Dependabot security alerts: - appengine/standard/firebase/firenotes/backend/requirements.txt: update pyjwt from 1.7.1 to 2.15.1 (python_version >= '3.10') - iap/requirements.txt: pin PyJWT to 2.15.1 - run/mcp-server/uv.lock: upgrade transitive pyjwt lock from 2.13.0 to 2.15.1 and normalize registry URLs to PyPI
product-auto-label
Bot
added
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the pyjwt dependency to version 2.15.1 across multiple requirements files. Feedback suggests simplifying the dependency specification in appengine/standard/firebase/firenotes/backend/requirements.txt by removing the unnecessary ; python_version >= '3.10' environment marker, since Python versions below 3.10 are no longer supported.
| @@ -1,5 +1,5 @@ | |||
| Flask==3.1.3; python_version >= '3.9' | |||
| pyjwt==1.7.1; python_version < '3.0' | |||
| pyjwt==2.15.1; python_version >= '3.10' | |||
Contributor
There was a problem hiding this comment.
Since Python versions below 3.10 are no longer supported, we should avoid specifying unnecessary environment markers like ; python_version >= '3.10'. We can simplify this by specifying pyjwt==2.15.1 directly, which is also consistent with how it is defined in iap/requirements.txt.
pyjwt==2.15.1
References
- Do not specify fallback dependency versions or environment markers for Python versions older than 3.10, as Python versions below 3.10 are no longer supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump PyJWT to 2.15.1 to resolve Dependabot security alerts:
Fixes b/572892896
Checklist
Testing
Compliance & Style
Post-Approval Actions