Skip to content

doc(run): update logging-manual deployment instructions to use Artifa… - #14636

Open
jungwonenjoyericl wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
jungwonenjoyericl:fix-logging-manual-registry
Open

jungwonenjoyericl wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
jungwonenjoyericl:fix-logging-manual-registry

Conversation

@jungwonenjoyericl

@jungwonenjoyericl jungwonenjoyericl commented Oct 12, 2026 •

Copy link
Copy Markdown

…ct Registry

Description

Fixes #14633

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style


Post-Approval Actions

  • Please merge this PR for me once it is approved

@jungwonenjoyericl
jungwonenjoyericl requested review from a team as code owners October 12, 2026 17:06
@product-auto-label product-auto-label Bot added api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples. labels Oct 12, 2026
@google-cla

google-cla Bot commented Oct 12, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the container registry paths in the README.md from Container Registry (gcr.io) to Artifact Registry (REGION-docker.pkg.dev). Feedback was provided to correct the Artifact Registry paths, which are currently missing the required repository segment in the path format.

Comment thread run/logging-manual/README.md Outdated
Comment on lines +37 to +41
gcloud builds submit --tag REGION-docker.pkg.dev/${GOOGLE_CLOUD_PROJECT}/logging-manual

# Deploy to Cloud Run
gcloud run deploy logging-manual \
--image gcr.io/${GOOGLE_CLOUD_PROJECT}/logging-manual \
--image REGION-docker.pkg.dev/${GOOGLE_CLOUD_PROJECT}/logging-manual \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Artifact Registry image paths require a repository name in addition to the project ID and image name, following the format LOCATION-docker.pkg.dev/PROJECT-ID/REPOSITORY/IMAGE. The current path REGION-docker.pkg.dev/${GOOGLE_CLOUD_PROJECT}/logging-manual is missing the repository segment. Please update it to include a placeholder like REPOSITORY.

Suggested change
gcloud builds submit --tag REGION-docker.pkg.dev/${GOOGLE_CLOUD_PROJECT}/logging-manual
# Deploy to Cloud Run
gcloud run deploy logging-manual \
--image gcr.io/${GOOGLE_CLOUD_PROJECT}/logging-manual \
--image REGION-docker.pkg.dev/${GOOGLE_CLOUD_PROJECT}/logging-manual \
gcloud builds submit --tag REGION-docker.pkg.dev/${GOOGLE_CLOUD_PROJECT}/REPOSITORY/logging-manual
# Deploy to Cloud Run
gcloud run deploy logging-manual \
--image REGION-docker.pkg.dev/${GOOGLE_CLOUD_PROJECT}/REPOSITORY/logging-manual \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

run/logging-manual: clarify Artifact Registry setup for deployment

1 participant