Repository navigation
doc(run): update logging-manual deployment instructions to use Artifa… - #14636
jungwonenjoyericl wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the container registry paths in the README.md from Container Registry (gcr.io) to Artifact Registry (REGION-docker.pkg.dev). Feedback was provided to correct the Artifact Registry paths, which are currently missing the required repository segment in the path format.
| gcloud builds submit --tag REGION-docker.pkg.dev/${GOOGLE_CLOUD_PROJECT}/logging-manual | ||
|
|
||
| # Deploy to Cloud Run | ||
| gcloud run deploy logging-manual \ | ||
| --image gcr.io/${GOOGLE_CLOUD_PROJECT}/logging-manual \ | ||
| --image REGION-docker.pkg.dev/${GOOGLE_CLOUD_PROJECT}/logging-manual \ |
There was a problem hiding this comment.
Artifact Registry image paths require a repository name in addition to the project ID and image name, following the format LOCATION-docker.pkg.dev/PROJECT-ID/REPOSITORY/IMAGE. The current path REGION-docker.pkg.dev/${GOOGLE_CLOUD_PROJECT}/logging-manual is missing the repository segment. Please update it to include a placeholder like REPOSITORY.
| gcloud builds submit --tag REGION-docker.pkg.dev/${GOOGLE_CLOUD_PROJECT}/logging-manual | |
| # Deploy to Cloud Run | |
| gcloud run deploy logging-manual \ | |
| --image gcr.io/${GOOGLE_CLOUD_PROJECT}/logging-manual \ | |
| --image REGION-docker.pkg.dev/${GOOGLE_CLOUD_PROJECT}/logging-manual \ | |
| gcloud builds submit --tag REGION-docker.pkg.dev/${GOOGLE_CLOUD_PROJECT}/REPOSITORY/logging-manual | |
| # Deploy to Cloud Run | |
| gcloud run deploy logging-manual \ | |
| --image REGION-docker.pkg.dev/${GOOGLE_CLOUD_PROJECT}/REPOSITORY/logging-manual \ |
…ct Registry
Description
Fixes #14633
Checklist
Testing
Compliance & Style
Post-Approval Actions