Skip to content

fix(recaptcha): demo views answered 500 instead of their JSON error body #14635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rootkiller6788 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(recaptcha): demo views answered 500 instead of their JSON error body #14635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions recaptcha_enterprise/demosite/app/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def on_signup() -> Response:
}
}
)
except ValueError or Exception as e:
except Exception as e:
return jsonify({"data": {"error_msg": str(e.__dict__)}})
Comment on lines +104 to 105

@gemini-code-assist gemini-code-assist Bot Oct 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using str(e.__dict__) typically returns an empty dictionary string ('{}') for standard Python exceptions because they do not store their error messages in __dict__. To return the actual error message, use str(e) instead.

Suggested change
except Exception as e:
return jsonify({"data": {"error_msg": str(e.__dict__)}})
except Exception as e:
return jsonify({"data": {"error_msg": str(e)}})



Expand Down Expand Up @@ -150,7 +150,7 @@ def on_login() -> Response:
}
}
)
except ValueError or Exception as e:
except Exception as e:
return jsonify({"data": {"error_msg": str(e.__dict__)}})
Comment on lines +153 to 154

@gemini-code-assist gemini-code-assist Bot Oct 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using str(e.__dict__) typically returns an empty dictionary string ('{}') for standard Python exceptions because they do not store their error messages in __dict__. To return the actual error message, use str(e) instead.

Suggested change
except Exception as e:
return jsonify({"data": {"error_msg": str(e.__dict__)}})
except Exception as e:
return jsonify({"data": {"error_msg": str(e)}})



Expand Down Expand Up @@ -198,7 +198,7 @@ def on_store_checkout() -> Response:
}
}
)
except ValueError or Exception as e:
except Exception as e:
return jsonify({"data": {"error_msg": str(e.__dict__)}})
Comment on lines +201 to 202

@gemini-code-assist gemini-code-assist Bot Oct 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using str(e.__dict__) typically returns an empty dictionary string ('{}') for standard Python exceptions because they do not store their error messages in __dict__. To return the actual error message, use str(e) instead.

Suggested change
except Exception as e:
return jsonify({"data": {"error_msg": str(e.__dict__)}})
except Exception as e:
return jsonify({"data": {"error_msg": str(e)}})



Expand Down Expand Up @@ -246,7 +246,7 @@ def on_comment_submit() -> Response:
}
}
)
except ValueError or Exception as e:
except Exception as e:
return jsonify({"data": {"error_msg": str(e.__dict__)}})
Comment on lines +249 to 250

@gemini-code-assist gemini-code-assist Bot Oct 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using str(e.__dict__) typically returns an empty dictionary string ('{}') for standard Python exceptions because they do not store their error messages in __dict__. To return the actual error message, use str(e) instead.

Suggested change
except Exception as e:
return jsonify({"data": {"error_msg": str(e.__dict__)}})
except Exception as e:
return jsonify({"data": {"error_msg": str(e)}})



Expand Down
Loading