Skip to content

fix(workbooks): restore kanban order when a drag is canceled - #4184

Merged
KATO-Hiro merged 4 commits into
stagingfrom
#4183
Oct 18, 2026
Merged

fix(workbooks): restore kanban order when a drag is canceled#4184
KATO-Hiro merged 4 commits into
stagingfrom
#4183

Conversation

@KATO-Hiro

@KATO-Hiro KATO-Hiro commented Oct 18, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

close #4183

Summary by CodeRabbit

  • 不具合修正
    • カンバンのドラッグ操作をキャンセルした際、操作前の列の状態に戻るようになりました。
    • 並べ替えに変更がない場合は保存を行わず、保存に失敗した場合は操作前の状態に戻るようになりました。
    • 保存中に新たなドラッグ操作を始めても、その操作前の状態が保持されるようになりました。

KATO-Hiro and others added 4 commits October 18, 2026 06:57
@KATO-Hiro @claude
fix(workbooks): restore kanban order when a drag is canceled
8b01d98 
Add resolveDragEndAction to decide between none, restore and save at drag
end, so pressing Escape no longer persists the moved order. Add a plan
for the dnd-kit 0.5.1 manual check.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@KATO-Hiro @claude
refactor(test): share swapped kanban columns fixture
5d590f2 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@KATO-Hiro @claude
docs: rewrite dnd-kit kanban plan as completed record
bbafcee 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@KATO-Hiro @claude
docs: remove dnd-kit kanban check plan
fe8cd37 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: AtCoder-NoviSteps/AtCoderNoviSteps/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7d52a7b2-a4be-42a8-acc6-d4cf36f640be
📥 Commits

Reviewing files that changed from the base of the PR and between 3e08938 and fe8cd37.

📒 Files selected for processing: 5
  • src/routes/(admin)/workbooks/order/_components/KanbanBoard.svelte
  • src/routes/(admin)/workbooks/order/_fixtures/kanban.ts
  • src/routes/(admin)/workbooks/order/_types/kanban.ts
  • src/routes/(admin)/workbooks/order/_utils/kanban.test.ts
  • src/routes/(admin)/workbooks/order/_utils/kanban.ts
+----------------------------------+
| Pulling the bugs out of the hat. |
+----------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

KATO-Hiro
KATO-Hiro commented Oct 18, 2026
View reviewed changes

@KATO-Hiro KATO-Hiro left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KATO-Hiro
KATO-Hiro merged commit 7667bbe into staging Oct 18, 2026
3 checks passed
@KATO-Hiro
KATO-Hiro deleted the #4183 branch October 18, 2026 08:13

This branch was successfully deployed

1 active deployment
preview — fe8cd37d Deployed Oct 18, 2026 by KATO-Hiro via preview #9003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: fix cancel action for kanban

1 participant

@KATO-Hiro